Conversation
|
|
||
| private | ||
|
|
||
| def report(title, step, substeps: 0, current_substep: 0) |
There was a problem hiding this comment.
Why not making it public and use it directly in the installer.rb?
I mean,
...
def install
...
Yast::Installation.destdir = "/mnt"
# Imaging we have a collection of steps or so where partitioning could be...
#
# class Partitioning < InstallationStep
# def start_label
# _("Partitioning target disk")
# end
#
# def perform
# Yast::WFM.CallFunction("inst_prepdisk", [])
# end
#
# ...
steps = [partitioning, package_installation, bootloader_installation]
# So...
progress = InstallationProgress.new(@dbus_obj, steps.size, logger: logger)
steps.each_with_index |step, index| do
progress.report(step.start_label, index)
step.perform
progress.report(step.end_label, index + 1)
end
...
end
...There was a problem hiding this comment.
well, I am still not sure whose responsibility it is. Also progress needs to know about number of steps so it can report it. So question is who owns responsibility for proper messaging. Still not sure what would be the best solution
There was a problem hiding this comment.
Also progress needs to know about number of steps so it can report it
Right. That's why I put the "steps.size" in the InstallationProgress constructor. To tell it the number of steps when creating it, instead of having an internal constant that must be in sync with the installer.rb.
Anyway, let's continue playing around. Thank you!
Changes on top of latest LVM features
## Problem According to [bsc#1258271](https://bugzilla.suse.com/show_bug.cgi?id=1258271) Agama selects the wrong `-release` package when using the immutable mode. However, Agama does not select any `-release` package, it just selects the base product. The problem is that both release packages provide the same product in this case (see [comment #7](https://bugzilla.suse.com/show_bug.cgi?id=1258271#c7)). ## Solution Add the corresponding release package to the list of `mandatory_packages` for each mode.
2 participants
No description provided.